[pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option

From: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option
Date: 2016-08-19 18:00:22
Message-ID: CAM5-9D-DqsVjBrR6odyvr8H6dY=n=Wd4qF07KPGgst8HYP56Cw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

*Issue:*
Two reasons:
1) In Resource group menu, the check for server connected or not is missing.
2) When server is disconnected, server type is always set to 'pg' which is
wrong and thus function always returns true.

*Solution:*
If server is disconnected, we should check server type based on its
maintenance db.
If maintenance db is 'edb' its ppas server, otherwise 'pg'.

Please review attached patch.

Thanks,
Surinder Kumar

Attachment Content-Type Size
RM1569.patch application/octet-stream 2.5 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-08-19 19:46:01 [pgAdmin4][Patch]: RM1251 - Tab complete for combo boxes
Previous Message Dave Page 2016-08-19 16:02:16 Re: PATCH/s: RM#1387 - Bad handling of missing connection database server