Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option
Date: 2016-08-19 20:09:29
Message-ID: A5A0634A-601F-47E5-9834-0572EEDAE922@pgadmin.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi

That's not a reliable check - you can just as easily use postgres as the maintenance db on epas.

Why don't we just hide the option if disconnected, and if connected, then check the server type?

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

> On 19 Aug 2016, at 19:00, Surinder Kumar <surinder(dot)kumar(at)enterprisedb(dot)com> wrote:
>
> Hi
>
> Issue:
> Two reasons:
> 1) In Resource group menu, the check for server connected or not is missing.
> 2) When server is disconnected, server type is always set to 'pg' which is wrong and thus function always returns true.
>
> Solution:
> If server is disconnected, we should check server type based on its maintenance db.
> If maintenance db is 'edb' its ppas server, otherwise 'pg'.
>
> Please review attached patch.
>
> Thanks,
> Surinder Kumar
> <RM1569.patch>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Surinder Kumar 2016-08-19 21:14:54 Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option
Previous Message Surinder Kumar 2016-08-19 19:46:01 [pgAdmin4][Patch]: RM1251 - Tab complete for combo boxes