| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: Free indexed_tlist memory explicitly within set_plan_refs() |
| Date: | 2015-05-30 22:30:37 |
| Message-ID: | CAM3SWZTgghD0HBgHAHBn7ekGh7oCZbEWw5UMy-C2A4tC3crjHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, May 30, 2015 at 3:12 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> Debugging this allowed me to come up with a significantly simplified
> approach. Attached is a new version of the original fix. Details are
> in commit message -- there is no actual need to have
> search_indexed_tlist_for_var() care about Vars being resjunk in a
> special way, which is a good thing.
It feels wrong to not have the additional, paranoid IsVar() check
within pull_var_targetlist_clause() check added in most recent
revision, even though it should not be necessary. Attached delta patch
adds this check.
I need to stop working on weekends...
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| additional-paranoid-check.patch | text/x-patch | 967 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2015-05-30 22:48:06 | Re: [CORE] postpone next week's release |
| Previous Message | Peter Geoghegan | 2015-05-30 22:12:17 | Re: Free indexed_tlist memory explicitly within set_plan_refs() |