Re: Free indexed_tlist memory explicitly within set_plan_refs()

On Sat, May 30, 2015 at 1:07 AM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> My fix for this issue
> (0001-Fix-bug-with-whole-row-Vars-in-excluded-targetlist.patch) still
> missed something. There needs to be additional handling in
> ruleutils.c:

Debugging this allowed me to come up with a significantly simplified
approach. Attached is a new version of the original fix. Details are
in commit message -- there is no actual need to have
search_indexed_tlist_for_var() care about Vars being resjunk in a
special way, which is a good thing. There is also no need for further
ruleutils.c specialization, as I implied before.

Some deparsing tests are now included on top of what was already in
the first version.
--
Peter Geoghegan