| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Cave-Ayland <mark(dot)cave-ayland(at)ilande(dot)co(dot)uk>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Joe Conway <mail(at)joeconway(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: Commitfest problems |
| Date: | 2014-12-15 20:05:58 |
| Message-ID: | CAM3SWZSmVQzXVgaCJJ25bD9UaAkEMPbLaVZcj_yskvO4YK_=1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Dec 15, 2014 at 11:52 AM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
> On 12/15/2014 11:27 AM, Robert Haas wrote:
>> I feel like we used to be better at encouraging people to participate
>> in the CF even if they were not experts, and to do the best they can
>> based on what they did know. That was a helpful dynamic. Sure, the
>> reviews weren't perfect, but more people helped, and reviewing some of
>> the patch well and some of it in a more cursory manner is way better
>> than reviewing none of it at all.
>
> Well, it was strongly expressed to me by a number of senior contributors
> on this list and at the developer meeting that inexpert reviews were not
> really wanted, needed or helpful. As such, I stopped recruiting new
> reviewers (and, for that matter, doing them myself). I don't know if
> the same goes for anyone else.
Really? I thought we were pretty consistent in encouraging new reviewers.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-12-15 20:11:55 | Re: WALWriter active during recovery |
| Previous Message | Josh Berkus | 2014-12-15 19:52:35 | Re: Commitfest problems |