| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Ian Barwick <ian(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Jim Nasby <jim(at)nasby(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Subject: | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Date: | 2014-11-13 17:15:55 |
| Message-ID: | CAM3SWZS4sg7PQN3Wsoxer3Kx4N0cN16h9bn9nmpqGDY2_d4dtg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 13, 2014 at 8:57 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> My point is: I am not sure I can be defined as a reviewer of this
>> patch or take any credit in this patch review knowing that the latest
>> version submitted is a simple rebase of the version I did my first
>> review on. Hence, code speaking, this patch is in the same state as
>> when it has been firstly submitted.
>
> Of course you can. Time spent reviewing is time spent reviewing,
> whether it results in changes to the patch or not.
My thoughts exactly. I thought Michael did a good job, even if I
didn't agree with everything he said.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-11-13 17:36:29 | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Previous Message | Robert Haas | 2014-11-13 16:57:41 | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |