| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com>, Ian Barwick <ian(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Jim Nasby <jim(at)nasby(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Subject: | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Date: | 2014-11-13 16:57:41 |
| Message-ID: | CA+Tgmoag_r6dku1ND9Y+3ra5jwaPD4xawyNhh5a_t=eks=4+3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 12, 2014 at 10:42 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Tue, Nov 11, 2014 at 3:52 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
>> I'm pretty puzzled by this. Other than our "agree to disagree and
>> defer to committer" position on the question of whether or not more
>> than one suggestion can come from a single RTE, which you were fine
>> with before [1], I have only restored the core/contrib separation to a
>> state recently suggested by Robert as the best and simplest all around
>> [2].
>> Did I miss something else?
> My point is: I am not sure I can be defined as a reviewer of this
> patch or take any credit in this patch review knowing that the latest
> version submitted is a simple rebase of the version I did my first
> review on. Hence, code speaking, this patch is in the same state as
> when it has been firstly submitted.
Of course you can. Time spent reviewing is time spent reviewing,
whether it results in changes to the patch or not.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2014-11-13 17:15:55 | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Previous Message | David G Johnston | 2014-11-13 16:54:56 | Re: controlling psql's use of the pager a bit more |