| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: lcr v5 - introduction of InvalidCommandId |
| Date: | 2013-09-05 18:42:25 |
| Message-ID: | CAM3SWZRS4gwcisAWrqSfKg=HnN+RpV=JbcZX7drR53QxTChX3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 5, 2013 at 11:30 AM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> Ideally I'd have made InvalidCommandId = 0 and FirstCommandId = 1,
>> but I suppose we can't have that without an on-disk compatibility break.
>
> The patch actually does change it exactly that way. My argument for that
> being valid is that CommandIds don't play any role outside of their own
> transaction.
Right. It seems like this should probably be noted in the
documentation under "5.4. System Columns" -- I just realized that it
isn't.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Blake Smith | 2013-09-05 18:42:56 | Re: Hstore: Query speedups with Gin index |
| Previous Message | Tom Lane | 2013-09-05 18:37:01 | Re: lcr v5 - introduction of InvalidCommandId |