From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Josh Berkus <josh(at)agliodbs(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: RFC: Remove contrib entirely |
Date: | 2015-05-29 22:08:13 |
Message-ID: | CAM3SWZQadEiReA7Q9XPy35LLqpZiRM92iQi-AuKJZMh+nYVO7Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, May 29, 2015 at 2:54 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Well, that module has already been rewritten once (which proves that
> there's an audience out there for it). Perhaps somebody will rewrite it
> again to support a non-hardwired set of ranges. Now that we have the
> concept of an extension configuration table, that'd be one possible
> way to fix it ...
I wouldn't bother.
ISBNs already have a UPC-style weighted sum check digit that will
catch the vast majority of errors, including all transposition errors.
You'd have to try hard to fatfinger an ISBN in a way that produced
something that accidentally had a valid check digit.
contrib/isn suffers from a bad case of protecting against Machiavelli
rather than Murphy. The enforcement isn't just obviously wrong, it's
also ridiculous in principle.
You're right, though -- we have better things to worry about.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Josh Berkus | 2015-05-29 22:08:27 | Re: RFC: Remove contrib entirely |
Previous Message | Robert Haas | 2015-05-29 22:02:36 | Re: [CORE] postpone next week's release |