| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Date: | 2015-05-20 22:14:17 |
| Message-ID: | CAM3SWZQXP3Z=iXQ_+HwoqG7417JYf6HKDTmgk-4Xt05OEL_S_Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, May 20, 2015 at 3:09 PM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>> Are you using an old psql? I thought that that would just result in no
>> command tag being displayed.
>
> Well, I'm using an editor to read the code of CreateCommandTag(), not
> executing anything. I guess that function needs an update, then, no?
I think you're right. The initial commit neglected to update that, and
only handled it from ProcessQuery(). So it works for PlannedStmts, not
raw parse trees.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | pgsql | 2015-05-20 22:19:54 | pgsql: Tag refs/tags/REL9_3_7 was created |
| Previous Message | Alvaro Herrera | 2015-05-20 22:09:11 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Banck | 2015-05-20 22:17:06 | Re: Disabling trust/ident authentication configure option |
| Previous Message | Alvaro Herrera | 2015-05-20 22:09:11 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |