| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Date: | 2015-05-20 22:09:11 |
| Message-ID: | 20150520220911.GK5885@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Geoghegan wrote:
> On Wed, May 20, 2015 at 2:58 PM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > Hm, I just realized that the command tag for INSERT ON CONFLICT is still
> > just INSERT. Is that okay? To me, the behavior is different enough
> > that it should have its own tag. I'm not too set on this, but maybe
> > others share this opinion?
>
> No it isn't. ON CONFLICT DO UPDATE has an "UPSERT" command tag. DO
> NOTHING has INSERT as its command tag.
... ah ...
> Are you using an old psql? I thought that that would just result in no
> command tag being displayed.
Well, I'm using an editor to read the code of CreateCommandTag(), not
executing anything. I guess that function needs an update, then, no?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-05-20 22:14:17 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Previous Message | Peter Geoghegan | 2015-05-20 22:02:05 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-05-20 22:14:17 | Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Previous Message | Alvaro Herrera | 2015-05-20 22:05:41 | Re: Disabling trust/ident authentication configure option |