Re: backup manifests

From: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
To: Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tels <nospam-pg-abuse(at)bloodgate(dot)com>, David Steele <david(at)pgmasters(dot)net>, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>
Subject: Re: backup manifests
Date: 2019-12-10 10:55:50
Message-ID: CAM2+6=XRenePvSYT3QOceHAY=Wz1KXf+jr_QBwkVM+uuE1B+3w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 10, 2019 at 3:29 PM Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>
wrote:

>
> Attaching another version of 0002 patch, as my collogue Jeevan Chalke
> pointed
> few indentation problem in 0002 patch which I sent earlier. Fixed the
> same in
> the latest patch.
>

I had a look over the new patch and see no issues. Looks good to me.
Thanks for quickly fixing the review comments posted earlier.

However, here are the minor comments:

1.
@@ -122,6 +133,7 @@ static long long int total_checksum_failures;
/* Do not verify checksums. */
static bool noverify_checksums = false;

+
/*
* The contents of these directories are removed or recreated during server
* start so they are not included in backups. The directories themselves
are

Please remove this unnecessary change.

Need to run the indentation.

Thanks
--
Jeevan Chalke
Associate Database Architect & Team Lead, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2019-12-10 11:20:44 RE: [Proposal] Level4 Warnings show many shadow vars
Previous Message Etsuro Fujita 2019-12-10 10:30:34 Re: [HACKERS] advanced partition matching algorithm for partition-wise join