| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Commitfest 2023-03 starting tomorrow! |
| Date: | 2023-04-04 18:36:01 |
| Message-ID: | CAM-w4HOYXzE=Kr3_FD5j=7ZLkKE1MTYWzYCiGu7uZAvnDdHxiA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 4 Apr 2023 at 11:18, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> > * clean up permission checks after 599b33b94
>
> I believe that the actual bug fixes are in, and what's left is just a test
> case that people weren't very excited about adding. So maybe this should
> get closed out as committed.
I'm not super convinced about this one. I'm not a big "all tests are
good tests" believer but this test seems like a pretty reasonable one.
Permissions checks and user mappings are user-visible behaviour that
are easy to overlook when making changes with unexpected side effects.
It seems like the test would be just as easy to commit as to not
commit and I don't see anything tricky about it that would necessitate
a more in depth review.
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-04-04 18:40:02 | Re: monitoring usage count distribution |
| Previous Message | Robert Haas | 2023-04-04 18:31:36 | Re: monitoring usage count distribution |