Re: [COMMITTERS] pgsql: Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than

On Sun, Sep 6, 2015 at 4:14 AM, Greg Stark <stark(at)mit(dot)edu> wrote:
>> Also, what about ecpg's copy of the code?
>
> That I hadn't thought of. Will look at it but it's after 4am here now
> so I'll get to it tomorrow.

So the only mention of these constants I can find in ECPG is the
structures in dt_common.c. I don't see a any code using it and I'm not
clear what the purpose of having this structure is or the significance
of changing it. Is this sufficient? Is it even necessary?

diff --git a/src/interfaces/ecpg/pgtypeslib/dt_common.c
b/src/interfaces/ecpg/pgtypeslib/dt_common.c
index 7fe2982..01cdfa9 100644
*** a/src/interfaces/ecpg/pgtypeslib/dt_common.c
--- b/src/interfaces/ecpg/pgtypeslib/dt_common.c
***************
*** 123,130 **** static datetkn datetktbl[] = {
{"dec", MONTH, 12},
{"december", MONTH, 12},
{"dnt", TZ, 3600}, /* Dansk Normal Tid */
! {"dow", RESERV, DTK_DOW}, /* day of week */
! {"doy", RESERV, DTK_DOY}, /* day of year */
{"dst", DTZMOD, SECS_PER_HOUR},
#if 0
{"dusst", DTZ, 21600}, /* Dushanbe Summer Time */
--- 123,130 ----
{"dec", MONTH, 12},
{"december", MONTH, 12},
{"dnt", TZ, 3600}, /* Dansk Normal Tid */
! {"dow", UNITS, DTK_DOW}, /* day of week */
! {"doy", UNITS, DTK_DOY}, /* day of year */
{"dst", DTZMOD, SECS_PER_HOUR},
#if 0
{"dusst", DTZ, 21600}, /* Dushanbe Summer Time */
***************
*** 206,212 **** static datetkn datetktbl[] = {
{"irkst", DTZ, 32400}, /* Irkutsk Summer Time */
{"irkt", TZ, 28800}, /* Irkutsk Time */
{"irt", TZ, 12600}, /* Iran Time */
! {"isodow", RESERV, DTK_ISODOW}, /* ISO day of week, Sunday == 7 */
#if 0
isst
#endif
--- 206,212 ----
{"irkst", DTZ, 32400}, /* Irkutsk Summer Time */
{"irkt", TZ, 28800}, /* Irkutsk Time */
{"irt", TZ, 12600}, /* Iran Time */
! {"isodow", UNITS, DTK_ISODOW}, /* ISO day of week, Sunday == 7 */
#if 0
isst
#endif

--
greg