| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Move DTK_ISODOW DTK_DOW and DTK_DOY to be type UNITS rather than |
| Date: | 2015-09-07 14:33:22 |
| Message-ID: | 8898.1441636402@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Greg Stark <stark(at)mit(dot)edu> writes:
>>> Also, what about ecpg's copy of the code?
> So the only mention of these constants I can find in ECPG is the
> structures in dt_common.c. I don't see a any code using it and I'm not
> clear what the purpose of having this structure is or the significance
> of changing it. Is this sufficient? Is it even necessary?
Hm. It does look like these entries might be dead code so far as ecpg
is concerned. I'd still make the changes you illustrate, just to avoid
having the ecpg code diverge further than necessary from the backend.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Stark | 2015-09-07 19:43:43 | pgsql: Change type of DOW/DOY to UNITS |
| Previous Message | Teodor Sigaev | 2015-09-07 14:22:12 | pgsql: Make GIN's cleanup pending list process interruptable |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-09-07 14:40:23 | Re: Creating unique or "internal-use-only" column names (ColumnRef) |
| Previous Message | Andrew Dunstan | 2015-09-07 14:07:12 | Re: Creating unique or "internal-use-only" column names (ColumnRef) |