| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly |
| Date: | 2022-12-26 12:42:34 |
| Message-ID: | CALj2ACXgPPAm28mruojSBno+F_=9cTOOxHAywu_dfZPeBdybQw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
It looks like assign_checkpoint_completion_target() is defined [1],
but never used, because of which CheckPointSegments may miss to
account for changed checkpoint_completion_target. I'm attaching a tiny
patch to fix this.
Thoughts?
[1]
commit 88e982302684246e8af785e78a467ac37c76dee9
Author: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Date: Mon Feb 23 18:53:02 2015 +0200
Replace checkpoint_segments with min_wal_size and max_wal_size.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Make-use-of-assign_checkpoint_completion_target-t.patch | application/x-patch | 805 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2022-12-26 12:42:55 | Make IsInstallXLogFileSegmentActive() an assert-only function |
| Previous Message | Hayato Kuroda (Fujitsu) | 2022-12-26 12:27:24 | RE: Exit walsender before confirming remote flush in logical replication |