| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Make IsInstallXLogFileSegmentActive() an assert-only function |
| Date: | 2022-12-26 12:42:55 |
| Message-ID: | CALj2ACUYtSSGQn-gei+B-VsBeEziFdb-FwXywmhKDkgL_XCmaw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
IsInstallXLogFileSegmentActive() is currently being used for assert
checks. How about making it an assert-only function to disable it on
production builds? This can shave an unused function on production
builds. We can easily switch back when there comes a real caller
outside of xlog.c. I'm attaching a tiny patch for this.
Thoughts?
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Make-IsInstallXLogFileSegmentActive-an-assert-onl.patch | application/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-12-26 13:02:24 | Re: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | Bharath Rupireddy | 2022-12-26 12:42:34 | Make use of assign_checkpoint_completion_target() to calculate CheckPointSegments correctly |