Re: Add last failed connection error message to pg_stat_wal_receiver

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Cary Huang <cary(dot)huang(at)highgo(dot)ca>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add last failed connection error message to pg_stat_wal_receiver
Date: 2022-07-25 06:49:40
Message-ID: CALj2ACWUb_XPGz1Rgh_YWHs1dqX2Q7uSPY5in4w=JXbx4FssDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Jul 23, 2022 at 2:29 AM Cary Huang <cary(dot)huang(at)highgo(dot)ca> wrote:
>
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> Hello
>
> The patch can be applied to PG master branch without problem and it passed regression and tap tests. I manually tested this feature too and the last conn error is correctly shown in the pg_stat_get_wal_receiver output, which does exactly as described. I think this feature is nice to have to troubleshoot replication issues on the standby side.

Thanks a lot Cary for reviewing. It will be great if you can add
yourself as a reviewer and set the status accordingly in the CF entry
here - https://commitfest.postgresql.org/38/3666/.

Regards,
Bharath Rupireddy.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2022-07-25 06:54:25 Re: SLRUs in the main buffer pool, redux
Previous Message Bharath Rupireddy 2022-07-25 06:39:26 Re: Remove useless arguments in ReadCheckpointRecord().