Re: Add BF member koel-like indentation checks to SanityCheck CI

On Wed, Jan 10, 2024 at 12:54 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > On Wed, Jan 10, 2024 at 01:25:36AM -0500, Tom Lane wrote:
> >> So that leads to the conclusion that I wouldn't want an automatic
> >> pgindent check to happen during "make all" or "make check", because
> >> I want those things to succeed before I consider pgindent'ing.
> >> Maybe it's okay to include it as part of check-world, but I'm
> >> not quite sure about that either.
>
> > Another possibility would be to hide the test behind a PG_TEST_EXTRA.
>
> Yeah. I'm not quite sure what's a good way to make this work, but
> it seems like having "make check-world" always invoke it would not
> be desirable. Making that conditional on an environment variable
> setting could be a better idea, perhaps?

It's easy to miss setting the environment variable and eventually end
up with code incompatible with pgindent committed. IMO, running the
pgindent in at least one of the CI systems if not all (either as part
task SyanityCheck or task Linux - Debian Bullseye - Autoconf) help
catches things early on in CF bot runs itself. This saves committers
time but at the cost of free run-time that cirrus-ci provides.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com