| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | John Naylor <johncnaylorls(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tristan Partin <tristan(at)neon(dot)tech>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Add BF member koel-like indentation checks to SanityCheck CI |
| Date: | 2024-01-10 07:24:14 |
| Message-ID: | 2363219.1704871454@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Wed, Jan 10, 2024 at 01:25:36AM -0500, Tom Lane wrote:
>> So that leads to the conclusion that I wouldn't want an automatic
>> pgindent check to happen during "make all" or "make check", because
>> I want those things to succeed before I consider pgindent'ing.
>> Maybe it's okay to include it as part of check-world, but I'm
>> not quite sure about that either.
> Another possibility would be to hide the test behind a PG_TEST_EXTRA.
Yeah. I'm not quite sure what's a good way to make this work, but
it seems like having "make check-world" always invoke it would not
be desirable. Making that conditional on an environment variable
setting could be a better idea, perhaps?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeremy Schneider | 2024-01-10 07:35:07 | Re: Built-in CTYPE provider |
| Previous Message | Michael Paquier | 2024-01-10 07:10:30 | Re: Add BF member koel-like indentation checks to SanityCheck CI |