| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Fix calculation of relid sets for partitionwise child joins. |
| Date: | 2023-07-22 03:41:08 |
| Message-ID: | CALj2ACVH=Eqri6tJ2oOBkiBpAF4wVcbPNsOhWoZCG0=RyD-1Qw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Sat, Jul 22, 2023 at 4:22 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>
> On Fri, 2023-07-21 at 16:00 +0000, Tom Lane wrote:
> > Fix calculation of relid sets for partitionwise child joins.
>
> In CI, I'm seeing a compiler warning here:
>
> https://cirrus-ci.com/task/6112262960709632
>
> [22:28:11.772] joinrels.c: In function ‘try_partitionwise_join’:
> [22:28:11.772] joinrels.c:1546:11: error: variable ‘child_joinrelids’
> set but not used [-Werror=unused-but-set-variable]
> [22:28:11.772] 1546 | Relids child_joinrelids;
> [22:28:11.772] | ^~~~~~~~~~~~~~~~
> [22:28:11.772] cc1: all warnings being treated as errors
Same here - https://github.com/BRupireddy/postgres/runs/15251297440.
Might have to mark the child_joinrelids PG_USED_FOR_ASSERTS_ONLY.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-07-22 14:33:02 | pgsql: Avoid compiler warning in non-assert builds. |
| Previous Message | Jeff Davis | 2023-07-21 22:51:54 | Re: pgsql: Fix calculation of relid sets for partitionwise child joins. |