From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Fix calculation of relid sets for partitionwise child joins. |
Date: | 2023-07-22 14:35:20 |
Message-ID: | 1163653.1690036520@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> writes:
> On Sat, Jul 22, 2023 at 4:22 AM Jeff Davis <pgsql(at)j-davis(dot)com> wrote:
>> On Fri, 2023-07-21 at 16:00 +0000, Tom Lane wrote:
>>> Fix calculation of relid sets for partitionwise child joins.
>> In CI, I'm seeing a compiler warning here:
>> [22:28:11.772] joinrels.c: In function ‘try_partitionwise_join’:
>> [22:28:11.772] joinrels.c:1546:11: error: variable ‘child_joinrelids’
>> set but not used [-Werror=unused-but-set-variable]
Right, I failed to test it without --enable-cassert, so I did not
see this warning.
> Might have to mark the child_joinrelids PG_USED_FOR_ASSERTS_ONLY.
It seemed better to me to put the adjust_child_relids call into
the Assert macro, so the compiler knows it doesn't have to run
adjust_child_relids in the non-Assert case.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-07-23 11:05:13 | pgsql: pgbench: Add TAP tests to check consistency of data generated |
Previous Message | Tom Lane | 2023-07-22 14:33:02 | pgsql: Avoid compiler warning in non-assert builds. |