| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Subject: | Re: logical replication worker accesses catalogs in error context callback |
| Date: | 2021-01-27 04:07:54 |
| Message-ID: | CALj2ACUkvABzq6yeKQZsgng5Rd_NF+ikhTvL9k4NR0GSRKsSdg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 27, 2021 at 7:48 AM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> For 0002, a few comments on the description:
>
> bq. Avoid accessing system catalogues inside conversion_error_callback
>
> catalogues -> catalog
>
> bq. error context callback, because the the entire transaction might
>
> There is redundant 'the'
>
> bq. Since get_attname() and get_rel_name() could search the sys cache by
> store the required information
>
> store -> storing
Thanks for pointing to the changes in the commit message. I corrected
them. Attaching v4 patch set, consider it for further review.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Avoid-Catalogue-Accesses-In-slot_store_error_call.patch | application/x-patch | 5.2 KB |
| v4-0002-Avoid-Catalogue-Accesses-In-conversion_error_call.patch | application/x-patch | 6.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2021-01-27 04:34:22 | Re: WIP: WAL prefetch (another approach) |
| Previous Message | Amit Kapila | 2021-01-27 03:53:21 | Re: Single transaction in the tablesync worker? |