Re: Create TOAST table only if AM needs

On Fri, May 17, 2019 at 11:34 AM Andres Freund <andres(at)anarazel(dot)de> wrote:

> Hi,
>
> On 2019-05-17 11:26:29 -0700, Ashwin Agrawal wrote:
> > Currently TOAST table is always created (if needed based on data type
> > properties) independent of table AM. How toasting is handled seems
> > should be AM responsibility. Generic code shouldn't force the use of
> > the separate table for the same. Like for Zedstore we store toasted
> > chunks in separate blocks but within the table file itself and don't
> > need separate toast table. Some other AM may implement the
> > functionality differently. So, similar to relation forks, usage of
> > toast table should be optional and left to AM to handle.
>
> Yea, Robert is also working on this. In fact, we were literally chatting
> about it a few minutes ago. He'll probably chime in too.
>

Thank You.

> My inclination is that it's too late for 12 to do anything about
> this. There are many known limitations, and we'll discover many more, of
> the current tableam interface. If we try to fix them for 12, we'll never
> get anywhere. It'll take a while to iron out all those wrinkles...
>

Agree on that, most of the stuff would be enhancements. And enhancements
can and will be made as we find them. Plus, will get added to the version
active in development that time. Intent is to start the discussion, and not
to convey a bug or has to be fixed in v12.