| From: | Ashwin Agrawal <aagrawal(at)pivotal(dot)io> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Create TOAST table only if AM needs |
| Date: | 2019-05-17 21:12:12 |
| Message-ID: | CALfoeisJn=+0uGA3qTyZE4aK7GwgVpLxxFNciXMO4_bTDqfNjQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 17, 2019 at 1:51 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> > /*
> ------------------------------------------------------------------------
> > * Planner related callbacks for the heap AM
> > @@ -2558,6 +2615,8 @@ static const TableAmRoutine heapam_methods = {
> >
> > .relation_estimate_size = heapam_estimate_rel_size,
> >
> > + .needs_toast_table = heapam_needs_toast_table,
> > +
>
> I'd rather see this have a relation_ prefix.
>
+1 to overall patch with that comment incorporated. This seems simple
enough to incorporate for v12. Though stating that blind-folded with what
else is remaining to be must done for v12.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashwin Agrawal | 2019-05-17 21:20:44 | Re: Create TOAST table only if AM needs |
| Previous Message | Andres Freund | 2019-05-17 20:55:49 | Re: New vacuum option to do only freezing |