Re: CREATE SCHEMA ... CREATE DOMAIN support

On Wed, 27 Nov 2024 at 08:42, jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> On Sat, Nov 23, 2024 at 1:19 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> >
> > I didn't add a doc entry. I will do it later.
> hi
> attached patch with thorough tests and documentation.
>

Hi! Thanks for pushing this further.

> one issue i still have is:
> CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
> create domain ss1 as ss
> create domain ss as text;
> ERROR: type "ss" does not exist
>
> the error message seems not that OK,
> if we can point out the error position, that would be great.
> like what we did with create schema create table:
>
> CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
> create table t(a int, b x);
> ERROR: type "x" does not exist
> LINE 2: create table t(a int, b x);
> ^

To implement this, we need to include `ParseLoc location` to the
`CreateDomainStmt` struct, which is doubtful, because I don't see any
other type of create *something* that does this.

`make check` on v3 runs successfully. Test & doc seems fine to me.

PFA v4. The only change I made is for a commit message, and pg indent
run on this diff.

--
Best regards,
Kirill Reshke