Re: CREATE SCHEMA ... CREATE DOMAIN support

From: jian he <jian(dot)universality(at)gmail(dot)com>
To: Kirill Reshke <reshkekirill(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE SCHEMA ... CREATE DOMAIN support
Date: 2024-11-27 03:42:12
Message-ID: CACJufxFUdgqDiK9B+VNtnAwZOj=O3NqdLtXO_OrOwE5XPdCpBA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Nov 23, 2024 at 1:19 PM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
>
> I didn't add a doc entry. I will do it later.
hi
attached patch with thorough tests and documentation.

one issue i still have is:
CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
create domain ss1 as ss
create domain ss as text;
ERROR: type "ss" does not exist

the error message seems not that OK,
if we can point out the error position, that would be great.
like what we did with create schema create table:

CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
create table t(a int, b x);
ERROR: type "x" does not exist
LINE 2: create table t(a int, b x);
^

Attachment Content-Type Size
v3-0001-support-CREATE-SCHEMA-.-CREATE-DOMAIN.patch text/x-patch 8.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2024-11-27 03:47:24 Re: CREATE SCHEMA ... CREATE DOMAIN support
Previous Message Amit Kapila 2024-11-27 03:20:28 Re: Improve the error message for logical replication of regular column to generated column.