Refine comments on usage WL_POSTMASTER_DEATH vs WL_EXIT_ON_PM_DEATH

From: Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>
To: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Refine comments on usage WL_POSTMASTER_DEATH vs WL_EXIT_ON_PM_DEATH
Date: 2024-10-23 09:18:03
Message-ID: CALT9ZEH6soOhgGB47FctuUE0zVa5zU2cnie67pLqKf4phOzyOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, Hackers!

Current comments on the usage of WL_POSTMASTER_DEATH state that it
should be used for scenarios of finishing other than immediately i.e.
returning values and waiting for postmaster dies.
In fact, in parts of the code, it's currently used to immediately exit or
throw FATAL (in the walsender and in libpq).

So I propose change the comments on WL_POSTMASTER_DEATH stating that it
could be used for both cases: for processing and setting return values if
that's needed, and for immediate exit otherwise.

Regards,
Pavel Borisov
Supabase

Attachment Content-Type Size
v1-0001-Refine-comments-on-usage-WL_POSTMASTER_DEATH.patch application/octet-stream 2.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Anthonin Bonnefoy 2024-10-23 09:24:11 Re: Set query_id for query contained in utility statement
Previous Message Amit Langote 2024-10-23 09:07:36 Re: Remove unnecessary word in a comment