Re: Pgoutput not capturing the generated columns

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com>
Subject: Re: Pgoutput not capturing the generated columns
Date: 2025-01-21 08:27:49
Message-ID: CALDaNm3zxQfJwYw7PwxtvYFAeCk6WkRt2iWu8HPWih8BubwU9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 20 Jan 2025 at 06:14, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh,
>
> Review comments for patch v53-0001:
>
>
> Maybe I have some fundamental misunderstanding here, but I don't see
> why "this approach cannot be used with psql because older version
> servers may not have these columns". Not having the columns is the
> whole point of using an alias approach in the first place e.g. the
> below table t1 does not have a column called "banana" but it works
> just fine to select an alias using that name...

This is simpler than maintaining the indexes. I misunderstood your
comment to include displaying the columns for older versions, I did
not want to display a value for the older versions as these columns do
not exist. I have updated the patch based on the alias approach. The
attached patch has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v54-0003-Fix-a-small-typo-in-publication-name.patch text/x-patch 6.1 KB
v54-0005-DOCS-Generated-Column-Replication.patch text/x-patch 12.7 KB
v54-0002-Add-missing-pubgencols-attribute-docs-for-pg_pub.patch text/x-patch 1.1 KB
v54-0001-Fix-incorrect-column-index-when-describing-publi.patch text/x-patch 1.6 KB
v54-0004-Change-publish_generated_columns-option-to-use-e.patch text/x-patch 91.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2025-01-21 08:33:29 Re: Eager aggregation, take 3
Previous Message Jeff Davis 2025-01-21 07:46:20 Re: Update Unicode data to Unicode 16.0.0