| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Shinoda, Noriyoshi (SXD Japan FSIP)" <noriyoshi(dot)shinoda(at)hpe(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "euler(at)eulerto(dot)com" <euler(at)eulerto(dot)com> |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2025-01-22 06:20:41 |
| Message-ID: | CAHut+PsnLbHKsq6rMecThChw0C4TAgoNEHBKH0HDa2auMQkzdQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 21, 2025 at 7:28 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Mon, 20 Jan 2025 at 06:14, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi Vignesh,
> >
> > Review comments for patch v53-0001:
> >
> >
> > Maybe I have some fundamental misunderstanding here, but I don't see
> > why "this approach cannot be used with psql because older version
> > servers may not have these columns". Not having the columns is the
> > whole point of using an alias approach in the first place e.g. the
> > below table t1 does not have a column called "banana" but it works
> > just fine to select an alias using that name...
>
> This is simpler than maintaining the indexes. I misunderstood your
> comment to include displaying the columns for older versions, I did
> not want to display a value for the older versions as these columns do
> not exist. I have updated the patch based on the alias approach. The
> attached patch has the changes for the same.
>
Patch v54-0001 LGTM.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2025-01-22 06:21:05 | add function argument name to substring and substr |
| Previous Message | Amul Sul | 2025-01-22 06:12:15 | Re: Allow NOT VALID foreign key constraints on partitioned tables. |