Re: Replication slot stats misgivings

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: Replication slot stats misgivings
Date: 2021-04-10 13:21:32
Message-ID: CALDaNm3LNZM2n6QTL4og_V96oNheB8assOdFcN6fEycUBC7KoQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 10, 2021 at 6:24 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sat, Apr 10, 2021 at 1:06 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > Thanks Amit for your Patch. I have merged your changes into my
> > patchset. I did not find any issues in my testing.
> > Thoughts?
> >
>
> 0001
> ------
> PgStat_Counter m_stream_bytes;
> + PgStat_Counter m_total_txns;
> + PgStat_Counter m_total_bytes;
> } PgStat_MsgReplSlot;
>
> ..
> ..
>
> + PgStat_Counter total_txns;
> + PgStat_Counter total_bytes;
> TimestampTz stat_reset_timestamp;
> } PgStat_ReplSlotStats;
>
> Doesn't this change belong to the second patch?

Missed it while splitting the patches, it is fixed in the attached patch,

Regards,
Vignesh

Attachment Content-Type Size
v6-0001-Changed-char-datatype-to-NameData-datatype-for-sl.patch text/x-patch 8.2 KB
v6-0002-Added-total-txns-and-total-txn-bytes-to-replicati.patch text/x-patch 20.6 KB
v6-0003-Added-tests-for-verification-of-logical-replicati.patch text/x-patch 5.7 KB
v6-0004-Handle-overwriting-of-replication-slot-statistic-.patch text/x-patch 2.8 KB
v6-0005-Test-where-there-are-more-replication-slot-statis.patch text/x-patch 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2021-04-10 14:33:10 Re: Is it worth to optimize VACUUM/ANALYZE by combining duplicate rel instances into single rel instance?
Previous Message Amit Kapila 2021-04-10 12:54:15 Re: Replication slot stats misgivings