Re: Replication slot stats misgivings

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: Replication slot stats misgivings
Date: 2021-04-10 12:54:15
Message-ID: CAA4eK1JRn5tT8uLL=nLT-PRRcvJi6BXVWJ-kv86E+q5rEY9rpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Apr 10, 2021 at 1:06 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks Amit for your Patch. I have merged your changes into my
> patchset. I did not find any issues in my testing.
> Thoughts?
>

0001
------
PgStat_Counter m_stream_bytes;
+ PgStat_Counter m_total_txns;
+ PgStat_Counter m_total_bytes;
} PgStat_MsgReplSlot;

..
..

+ PgStat_Counter total_txns;
+ PgStat_Counter total_bytes;
TimestampTz stat_reset_timestamp;
} PgStat_ReplSlotStats;

Doesn't this change belong to the second patch?

--
With Regards,
Amit Kapila.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2021-04-10 13:21:32 Re: Replication slot stats misgivings
Previous Message John Naylor 2021-04-10 12:53:28 Re: truncating timestamps on arbitrary intervals