| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-07-20 15:06:21 |
| Message-ID: | CALDaNm2vuO7Ya4QVTZKR9jY_mkFFcE_hKUJiXx4KUknPgGFjSg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 10 Jul 2024 at 09:34, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Fri, Jul 5, 2024 at 9:58 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > On Thu, 4 Jul 2024 at 12:44, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> > >
> > > 1.
> > > Should there be some new test for the view? Otherwise, AFAICT this
> > > patch has no tests that will exercise the new function
> > > pg_get_publication_sequences.
> >
> > pg_publication_sequences view uses pg_get_publication_sequences which
> > will be tested with 3rd patch while creating subscription/refreshing
> > publication sequences. I felt it is ok not to have a test here.
> >
>
> OTOH, if there had been such a test here then the ("sequence = NIL")
> bug in patch 0002 code would have been caught earlier in patch 0002
> testing instead of later in patch 0003 testing. In general, I think
> each patch should be self-contained w.r.t. to testing all of its new
> code, but if you think another test here is overkill then I am fine
> with that too.
Moved these changes to 0003 patch where it is actually required.
> //////////
>
> Meanwhile, here are my review comments for patch v20240705-0002
All the comments are fixed and the attached v20240720 version patch
has the changes for the same.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v20240720-0001-Introduce-pg_sequence_state-and-SetSequenc.patch | text/x-patch | 13.9 KB |
| v20240720-0003-Enhance-sequence-synchronization-during-su.patch | text/x-patch | 74.3 KB |
| v20240720-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch | text/x-patch | 90.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2024-07-20 15:08:18 | Re: Logical Replication of sequences |
| Previous Message | Andrew Dunstan | 2024-07-20 13:41:27 | Re: meson vs windows perl |