Re: Fix couple of typos

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix couple of typos
Date: 2025-03-18 03:19:22
Message-ID: CALDaNm2pJZNnfR0GqaAJHv5fw+Mmvf7GCdWmAD-nW=XVA9DBOA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 17 Mar 2025 at 16:57, Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>
> On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > >
> > > While reviewing another patch, I found a couple of typos:
> > > 1) subid should have been pubid in AlterPublicationOwner and
> > > AlterPublicationOwner_oid functions.
> > > 2) Only tuples with XIDs/MXIDs older than the the
> > > FreezeLimit/MultiXactCutoff are frozen in the common case.
> > > Should have been"
> > > Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff
> > > are frozen in the common case.
> > >
> > > The attached patch has the changes for the same.
> > >
> >
> > The changes look good to me.
>
> +1
>
> However they look unrelated. We should split them in two commits
> s/subid/pubid/ to one and s/the the/the/ to another. I also verified
> that this is the only occurrence of "the the" in the code base.

Thanks, the updated v2 has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v2-0001-Fix-typo.patch text/x-patch 1.1 KB
v2-0002-Fix-typo.patch text/x-patch 2.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-03-18 03:20:16 Re: add function argument name to substring and substr
Previous Message Thomas Munro 2025-03-18 03:18:17 Re: Allow io_combine_limit up to 1MB