Re: Fix couple of typos

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix couple of typos
Date: 2025-03-17 11:27:31
Message-ID: CAExHW5v8YuTVvN+rru9Bv3opR1FWRDv+LxEkNf-EbH7i=qFOHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 17, 2025 at 4:46 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Mar 17, 2025 at 3:44 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
> > While reviewing another patch, I found a couple of typos:
> > 1) subid should have been pubid in AlterPublicationOwner and
> > AlterPublicationOwner_oid functions.
> > 2) Only tuples with XIDs/MXIDs older than the the
> > FreezeLimit/MultiXactCutoff are frozen in the common case.
> > Should have been"
> > Only tuples with XIDs/MXIDs older than the FreezeLimit/MultiXactCutoff
> > are frozen in the common case.
> >
> > The attached patch has the changes for the same.
> >
>
> The changes look good to me.

+1

However they look unrelated. We should split them in two commits
s/subid/pubid/ to one and s/the the/the/ to another. I also verified
that this is the only occurrence of "the the" in the code base.

--
Best Wishes,
Ashutosh Bapat

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2025-03-17 11:32:43 Re: Proposal: Deferred Replica Filtering for PostgreSQL Logical Replication
Previous Message Hayato Kuroda (Fujitsu) 2025-03-17 11:26:34 RE: long-standing data loss bug in initial sync of logical replication