From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
Subject: | Re: [16+] subscription can end up in inconsistent state |
Date: | 2023-11-27 04:56:12 |
Message-ID: | CALDaNm2L9uDP3HsgSiBUGQWQAxVviA_BdcTHRUUiXTDJMpKD1Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs |
On Fri, 6 Oct 2023 at 12:26, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Thu, Oct 5, 2023 at 9:50 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
>
> > > 3. Connection string option 'passfile'?
> > >
> > > IIUC the subscription "password_required" option means that the
> > > password must be in the connection string. I'm not sure how the other
> > > connection string "passfile" option [2] fits into this rule. The
> > > current patch looks like it would reject the passfile option (because
> > > IIUC libpqrcv_check_conninfo only looks for "password") -- is it
> > > deliberate? And, should it be documented/commented somewhere?
> > >
> > > ======
> > > src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
> >
> > I felt we should not allow password from the passfile for
> > non-superusers, if password_required is true, the password can be
> > specified only through the password option of the connection string.
> > The same has been documented.
> >
>
> Assuming that everybody is happy with the above decision to only allow
> the 'password' parameter, then your latest v5-0001 patch looked good
> to me.
The patch was not applying on HEAD because of recent commits, the
attached v6 version patch is rebased on top of HEAD.
Regards,
Vignesh
Attachment | Content-Type | Size |
---|---|---|
v6-0001-A-non-superuser-is-only-allowed-to-specify-the-pa.patch | text/x-patch | 6.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Sri Mrudula Attili | 2023-11-27 11:50:26 | Re:Could not read from file "pg_subtrans/00F5" at offset 122880: Success. |
Previous Message | Etsuro Fujita | 2023-11-27 03:05:03 | Re: BUG #17828: postgres_fdw leaks file descriptors on error and aborts aborted transaction in lack of fds |