| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: [16+] subscription can end up in inconsistent state |
| Date: | 2024-01-12 21:55:28 |
| Message-ID: | 5438ebe33bce797e5ffe24eaca81f1d130af9617.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, 2023-11-27 at 10:26 +0530, vignesh C wrote:
> The patch was not applying on HEAD because of recent commits, the
> attached v6 version patch is rebased on top of HEAD.
Thank you, committed with minor modifications.
I decided to do:
libpqrcv_check_conninfo(conninfo, must_use_password);
rather than:
if (must_use_password)
libpqrcv_check_conninfo(conninfo, true);
because if there's some parsing error then we wouldn't like it to be
conditional on must_use_password. Of course, there should not be any
parsing error because it was already validated at DDL time, but in case
there's another way to get into an inconsistent state, we might as well
re-validate here.
Regards,
Jeff Davis
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2024-01-13 03:50:25 | Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends |
| Previous Message | Tom Lane | 2024-01-12 20:52:47 | Re: BUG #17798: Incorrect memory access occurs when using BEFORE ROW UPDATE trigger |