From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Improve tab completion for ALTER DEFAULT PRIVILEGE and ALTER TABLE |
Date: | 2023-09-25 17:07:38 |
Message-ID: | CALDaNm216Gta60DrXbEYq6TsAo=x2K1w2C-uTYLax7Y_LyWexQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, 2 Jul 2023 at 20:42, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Hi,
>
> Improved tab completion for "ALTER DEFAULT PRIVILEGE" and "ALTER TABLE":
> 1) GRANT, REVOKE and FOR USER keyword was not displayed in tab
> completion of alter default privileges like the below statement:
> ALTER DEFAULT PRIVILEGES GRANT INSERT ON tables TO PUBLIC;
> ALTER DEFAULT PRIVILEGES REVOKE INSERT ON tables FROM PUBLIC;
> ALTER DEFAULT PRIVILEGES FOR USER vignesh revoke INSERT ON tables FROM dba1;
>
> 2) USER was not displayed for "ALTER DEFAULT PRIVILEGES IN SCHEMA
> public FOR " like in below statement:
> ALTER DEFAULT PRIVILEGES IN SCHEMA public FOR USER dba1 GRANT INSERT
> ON TABLES TO PUBLIC;
>
> 3) "FOR GRANT OPTION" was not display for "ALTER DEFAULT PRIVILEGES
> REVOKE " like in below statement:
> alter default privileges revoke grant option for select ON tables FROM dba1;
>
> 4) "DATA TYPE" was missing in "ALTER TABLE table-name ALTER COLUMN
> column-name SET" like in:
> ALTER TABLE t1 ALTER COLUMN c1 SET DATA TYPE text;
>
> Attached patch has the changes for the same.
Added a commitfest entry for this:
https://commitfest.postgresql.org/45/4587/
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | Matthias van de Meent | 2023-09-25 17:16:50 | Re: XLog size reductions: smaller XLRec block header for PG17 |
Previous Message | Matthias van de Meent | 2023-09-25 16:13:19 | Re: Improving btree performance through specializing by key shape, take 2 |