From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Improve tab completion for ALTER DEFAULT PRIVILEGE and ALTER TABLE |
Date: | 2023-07-02 15:12:06 |
Message-ID: | CALDaNm1aEdJb-QJi=GWStkfj_+EDUK_VtDkn+TjQ2z7HyU0MBw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Improved tab completion for "ALTER DEFAULT PRIVILEGE" and "ALTER TABLE":
1) GRANT, REVOKE and FOR USER keyword was not displayed in tab
completion of alter default privileges like the below statement:
ALTER DEFAULT PRIVILEGES GRANT INSERT ON tables TO PUBLIC;
ALTER DEFAULT PRIVILEGES REVOKE INSERT ON tables FROM PUBLIC;
ALTER DEFAULT PRIVILEGES FOR USER vignesh revoke INSERT ON tables FROM dba1;
2) USER was not displayed for "ALTER DEFAULT PRIVILEGES IN SCHEMA
public FOR " like in below statement:
ALTER DEFAULT PRIVILEGES IN SCHEMA public FOR USER dba1 GRANT INSERT
ON TABLES TO PUBLIC;
3) "FOR GRANT OPTION" was not display for "ALTER DEFAULT PRIVILEGES
REVOKE " like in below statement:
alter default privileges revoke grant option for select ON tables FROM dba1;
4) "DATA TYPE" was missing in "ALTER TABLE table-name ALTER COLUMN
column-name SET" like in:
ALTER TABLE t1 ALTER COLUMN c1 SET DATA TYPE text;
Attached patch has the changes for the same.
Regards,
Vignesh
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-missing-tab-completion-in-ALTER-DEFAULT-PRIVILEG.patch | text/x-patch | 2.7 KB |
0002-Fix-missing-tab-completion-in-ALTER-TABLE-table-name.patch | text/x-patch | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2023-07-02 16:09:12 | Re: BRIN indexes vs. SK_SEARCHARRAY (and preprocessing scan keys) |
Previous Message | Tommy Pavlicek | 2023-07-02 14:42:53 | Re: [PATCH] Extend ALTER OPERATOR to support adding commutator, negator, hashes, and merges |