Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Shubham Khanna <khannashubham1197(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.
Date: 2025-03-20 10:11:01
Message-ID: CALDaNm2=+JfyeUAY8UX2AEBrn2LDv1b+c+o0KnCxeMHWCgCeaQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 20 Mar 2025 at 10:25, Shubham Khanna
<khannashubham1197(at)gmail(dot)com> wrote:
>
>
> I have created two patches, v16-0001 and v16-0002, to address the
> performance issue. I conducted performance testing, and here are the
> results:
> - The difference in execution time between HEAD and the v15 patch was 53.2%.
> - After removing the suggested test cases, the difference reduced to
> 36.43%, showing a significant improvement.
>

It is still taking quite a while, can we compare with the following
too see how much extra time it takes:
a) remove insert and select verification for the all database
successful tests as all of these are logical replication verification
which is extensively tested b) remove command_fails_like failure tests
c) remove both of above and see.

Regards,
Vignesh

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dmitry Dolgov 2025-03-20 10:21:18 Re: Changing shared_buffers without restart
Previous Message Peter Eisentraut 2025-03-20 10:01:37 Re: RFC: Additional Directory for Extensions