Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided.

On Thu, Mar 20, 2025 at 3:41 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Thu, 20 Mar 2025 at 10:25, Shubham Khanna
> <khannashubham1197(at)gmail(dot)com> wrote:
> >
> >
> > I have created two patches, v16-0001 and v16-0002, to address the
> > performance issue. I conducted performance testing, and here are the
> > results:
> > - The difference in execution time between HEAD and the v15 patch was 53.2%.
> > - After removing the suggested test cases, the difference reduced to
> > 36.43%, showing a significant improvement.
> >
>
> It is still taking quite a while, can we compare with the following
> too see how much extra time it takes:
> a) remove insert and select verification for the all database
> successful tests as all of these are logical replication verification
> which is extensively tested b) remove command_fails_like failure tests
> c) remove both of above and see.
>

As suggested by Amit at [1], I have reduced the number of test cases
in the v17-0001 patch to ensure they are concise and focused.
I conducted performance testing on the current HEAD and the latest
v17-0001 patch (available at [2]). Here are the observations based on
five runs:-
- The difference in execution time between HEAD and the v17-0001 patch
was 1.62 seconds.
- This corresponds to a 22.44% difference in performance.

[1] - https://www.postgresql.org/message-id/CAA4eK1KUDEO0t6i16_CcEpg33sgcgEddHcdVC_q8j4tVUb5FWw%40mail.gmail.com
[2] - https://www.postgresql.org/message-id/CAHv8RjLj0KxVHbxaPZHzudGS1igzDMccFE8LDh4LHNJR_2Aqug%40mail.gmail.com

Thanks and regards,
Shubham Khanna.