Re: Logical Replication of sequences

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: Re: Logical Replication of sequences
Date: 2024-07-24 06:37:01
Message-ID: CALDaNm1uncevCSMqo5Nk=tqqV_o3KNH_jwp8URiGop_nPC8BTg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 24 Jul 2024 at 09:17, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi, here are some review comments for patch v20240720-0003.
>
> This review is a WIP. This post is only about the docs (*.sgml) of patch 0003.
>
> 3. catalogs.sgml
>
> IMO something is missing in Section "1.55. pg_subscription_rel".
>
> Currently, this page only talks of relations/tables, but I think it
> should mention "sequences" here too, particularly since now we are
> linking to here from ALTER SUBSCRIPTION when talking about sequences.

Modified it to mention sequences too.

I have merged the rest of the nitpicks suggested by you.
The attached v20240724 version patch has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v20240724-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch text/x-patch 90.2 KB
v20240724-0003-Enhance-sequence-synchronization-during-su.patch text/x-patch 76.5 KB
v20240724-0001-Introduce-pg_sequence_state-and-SetSequenc.patch text/x-patch 13.9 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-07-24 06:40:01 Re: Logical Replication of sequences
Previous Message jian he 2024-07-24 06:24:55 Re: pgsql: Add more SQL/JSON constructor functions