| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
| Subject: | Re: Logical Replication of sequences |
| Date: | 2024-08-21 06:24:28 |
| Message-ID: | CALDaNm1nWLaHMphq_u2yJrXJFusE0hiWmpcinpYPN_ab0ZfrbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 21 Aug 2024 at 08:33, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh, Here are my only review comments for the latest patch set.
Thanks, these issues have been addressed in the updated version.
Additionally, I have fixed the pgindent problems that were reported
and included another advantage of this design in the file header of
the sequencesync file.
Regards,
Vignesh
| Attachment | Content-Type | Size |
|---|---|---|
| v20240821-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch | text/x-patch | 23.0 KB |
| v20240821-0004-Enhance-sequence-synchronization-during-su.patch | text/x-patch | 89.7 KB |
| v20240821-0001-Introduce-pg_sequence_state-function-for-e.patch | text/x-patch | 11.4 KB |
| v20240821-0005-Documentation-for-sequence-synchronization.patch | text/x-patch | 23.1 KB |
| v20240821-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch | text/x-patch | 90.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-08-21 06:25:13 | Re: Taking into account syncrep position in flush_lsn reported by apply worker |
| Previous Message | Peter Eisentraut | 2024-08-21 06:17:45 | Disallow USING clause when altering type of generated column |