Re: Logical Replication of sequences

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: Re: Logical Replication of sequences
Date: 2024-09-20 04:06:44
Message-ID: CALDaNm0-cR7jKJ-ZJUXzzOEqBRB-cpStx=48RuCn5gHO9r+oog@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 21 Aug 2024 at 11:54, vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Wed, 21 Aug 2024 at 08:33, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > Hi Vignesh, Here are my only review comments for the latest patch set.
>
> Thanks, these issues have been addressed in the updated version.
> Additionally, I have fixed the pgindent problems that were reported
> and included another advantage of this design in the file header of
> the sequencesync file.

The patch was not applied on top of head, here is a rebased version of
the patches.
I have also removed an invalidation which was not required for
sequences and a typo.

Regards,
Vignesh

Attachment Content-Type Size
v20240920-0001-Introduce-pg_sequence_state-function-for-e.patch text/x-patch 11.4 KB
v20240920-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch text/x-patch 89.4 KB
v20240920-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch text/x-patch 23.0 KB
v20240920-0005-Documentation-for-sequence-synchronization.patch text/x-patch 23.1 KB
v20240920-0004-Enhance-sequence-synchronization-during-su.patch text/x-patch 89.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tender Wang 2024-09-20 04:14:12 Re: not null constraints, again
Previous Message Nisha Moond 2024-09-20 04:03:56 Re: Conflict Detection and Resolution