Re: Alter all tables in schema owner fix

From: vignesh C <vignesh21(at)gmail(dot)com>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>
Cc: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Subject: Re: Alter all tables in schema owner fix
Date: 2021-12-07 02:51:40
Message-ID: CALDaNm1Qxau9_LTEpxfG7EmGE=O8YXGeX4hKMBYAt3-U+-WD1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 3, 2021 at 10:50 PM Bossart, Nathan <bossartn(at)amazon(dot)com> wrote:
>
> On 12/2/21, 11:57 PM, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com> wrote:
> > Thanks for your patch.
> > I tested it and it fixed this problem as expected. It also passed "make check-world".
>
> +1, the patch looks good to me, too. My only other suggestion would
> be to move IsSchemaPublication() to pg_publication.c

Thanks for your comments, I have made the changes. Additionally I have
renamed IsSchemaPublication to is_schema_publication for keeping the
naming similar around the code. The attached v3 patch has the changes
for the same.

Regards,
Vignesh

Attachment Content-Type Size
v3-0001-Fix-for-new-owner-of-ALL-TABLES-IN-SCHEMA-publica.patch text/x-patch 5.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2021-12-07 03:23:27 Re: parallel vacuum comments
Previous Message Peter Geoghegan 2021-12-07 02:42:14 Re: Why doesn't pgstat_report_analyze() focus on not-all-visible-page dead tuple counts, specifically?