Re: Alter all tables in schema owner fix

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Greg Nancarrow <gregn4422(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>
Subject: Re: Alter all tables in schema owner fix
Date: 2021-12-07 10:00:59
Message-ID: CAA4eK1LtKKEF6q_Y3dKckHoWxBvxV1qYBicxyQPE=YUkb1q-Pg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 7, 2021 at 8:21 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> Thanks for your comments, I have made the changes. Additionally I have
> renamed IsSchemaPublication to is_schema_publication for keeping the
> naming similar around the code. The attached v3 patch has the changes
> for the same.
>

Thanks, the patch looks mostly good to me. I have slightly modified it
to incorporate one of Michael's suggestions, ran pgindent, and
modified the commit message.

I am planning to push the attached tomorrow unless there are further
comments. Michael, do let me know if you have any questions or
objections about this?

--
With Regards,
Amit Kapila.

Attachment Content-Type Size
v4-0001-Fix-changing-the-ownership-of-ALL-TABLES-IN-SCHEM.patch application/octet-stream 5.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2021-12-07 10:07:42 Re: Add sub-transaction overflow status in pg_stat_activity
Previous Message kuroda.hayato@fujitsu.com 2021-12-07 09:48:21 RE: Allow escape in application_name