From: | vignesh C <vignesh21(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
Subject: | Re: Replication slot stats misgivings |
Date: | 2021-03-30 04:43:29 |
Message-ID: | CALDaNm0xxc-DhfQr-RdEKseCwPdojUDoy_yav7h_YvFXponPHw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Mar 30, 2021 at 6:28 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2021-03-26 07:58:58 +0530, Amit Kapila wrote:
> > On Fri, Mar 26, 2021 at 1:17 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > > I suggest we wait doing anything about this until we know if the shared
> > > stats patch gets in or not (I'd give it 50% maybe). If it does get in
> > > things get a good bit easier, because we don't have to deal with the
> > > message loss issues anymore.
> > >
> >
> > Okay, that makes sense.
>
> Any chance you could write a tap test exercising a few of these cases?
I can try to write a patch for this if nobody objects.
> E.g. things like:
>
> - create a few slots, drop one of them, shut down, start up, verify
> stats are still sane
> - create a few slots, shut down, manually remove a slot, lower
> max_replication_slots, start up
Here by "manually remove a slot", do you mean to remove the slot
manually from the pg_replslot folder?
> IMO, independent of the shutdown / startup issue, it'd be worth writing
> a patch tracking the bytes sent independently of the slot stats storage
> issues. That would also make the testing for the above cheaper...
I can try to write a patch for this if nobody objects.
Regards,
Vignesh
From | Date | Subject | |
---|---|---|---|
Next Message | Ajin Cherian | 2021-03-30 04:48:30 | Re: [PATCH] add concurrent_abort callback for output plugin |
Previous Message | Peter Smith | 2021-03-30 04:29:35 | Redundant errdetail prefix "The error was:" in some logical replication messages |