From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
---|---|
To: | Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com> |
Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: [PATCH] add concurrent_abort callback for output plugin |
Date: | 2021-03-30 04:48:30 |
Message-ID: | CAFPTHDYS3VU_Kqb7Ty9X0opXTOrjSJ=pkMJW_DAB-TucH+1c-w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Mar 29, 2021 at 10:09 PM Markus Wanner <
markus(dot)wanner(at)enterprisedb(dot)com> wrote:
> On 29.03.21 13:02, Ajin Cherian wrote:
> > Nice catch, Markus.
> > Interesting suggestion Amit. Let me try and code this.
>
> Thanks, Ajin. Please consider this concurrent_abort callback as well.
> I think it provides more flexibility for the output plugin and I would
> therefore prefer it over a solution that hides this. It clearly makes
> all potential optimizations impossible, as it means the output plugin
> cannot distinguish between a proper PREAPRE and a bail-out PREPARE (that
> does not fully replicate the PREPARE as on the origin node, either,
> which I think is dangerous).
>
>
I understand your concern Markus, but I will leave it to one of the
committers to decide on the new callback.
For now, I've created a patch that addresses the problem reported using the
existing callbacks.
Do have a look if this fixes the problem reported.
regards,
Ajin Cherian
Fujitsu Australia
Attachment | Content-Type | Size |
---|---|---|
v1-0001-Make-sure-a-prepare-is-sent-when-decoder-detects-.patch | application/octet-stream | 1.3 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-03-30 04:51:15 | Re: making update/delete of inheritance trees scale better |
Previous Message | vignesh C | 2021-03-30 04:43:29 | Re: Replication slot stats misgivings |