| From: | vignesh C <vignesh21(at)gmail(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Avoid updating inactive_since for invalid replication slots |
| Date: | 2025-02-04 06:35:40 |
| Message-ID: | CALDaNm0QFB1C6xVKfpS2FtPwBbxW0W-yRh9nOCdzGY=EvAd=Dg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, 4 Feb 2025 at 11:52, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> Here is the v2 patch with above change and other comments from [1] and
> [2] incorporated.
One small suggestion:
Since we will not be retaining inactive time for invalid slots after
server restart, the inactive time will be lost in this case, shouldn't
we include mentioning that too:
The time when the slot became inactive. <literal>NULL</literal> if the
- slot is currently being streamed.
+ slot is currently being streamed. If the slot becomes invalid,
+ this value will not be updated.
Regards,
Vignesh
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zharkov Roman | 2025-02-04 06:37:29 | Re: plperl version on the meson setup summary screen |
| Previous Message | Amit Kapila | 2025-02-04 06:32:51 | Re: Increased work_mem for "logical replication tablesync worker" only? |