| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com> |
| Subject: | Re: Avoid updating inactive_since for invalid replication slots |
| Date: | 2025-02-04 06:50:23 |
| Message-ID: | CAA4eK1KQroyVV+jXMjCGhwNMOkfa-6pm=_SpOm1UFx5x9N+Pow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Feb 4, 2025 at 12:05 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> On Tue, 4 Feb 2025 at 11:52, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > Here is the v2 patch with above change and other comments from [1] and
> > [2] incorporated.
>
> One small suggestion:
> Since we will not be retaining inactive time for invalid slots after
> server restart, the inactive time will be lost in this case, shouldn't
> we include mentioning that too:
> The time when the slot became inactive. <literal>NULL</literal> if the
> - slot is currently being streamed.
> + slot is currently being streamed. If the slot becomes invalid,
> + this value will not be updated.
>
The current update seems sufficient even for restart cases. It
indicates that inactive_sinsce is not updated for invalid slots
whether its restart or otherwise.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-02-04 07:03:55 | Re: Show WAL write and fsync stats in pg_stat_io |
| Previous Message | Daniel Gustafsson | 2025-02-04 06:39:12 | Re: new commitfest transition guidance |